Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for vikidia.org to avoid error "unable to hack startup module" #1783

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

pavel-karatsiuba
Copy link
Contributor

@pavel-karatsiuba pavel-karatsiuba commented Feb 15, 2023

Replacing script.src with an empty string if it contains load.php
Added test for getting articles from vikidia.org

fixes #1778

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 69.64% // Head: 70.31% // Increases project coverage by +0.66% 🎉

Coverage data is based on head (2c75a30) compared to base (89abe74).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1783      +/-   ##
==========================================
+ Coverage   69.64%   70.31%   +0.66%     
==========================================
  Files          23       23              
  Lines        2583     2584       +1     
  Branches      590      590              
==========================================
+ Hits         1799     1817      +18     
+ Misses        674      661      -13     
+ Partials      110      106       -4     
Impacted Files Coverage Δ
src/config.ts 100.00% <ø> (ø)
src/util/const.ts 100.00% <100.00%> (ø)
src/util/dump.ts 76.62% <100.00%> (ø)
src/Downloader.ts 59.87% <0.00%> (+0.61%) ⬆️
src/util/saveArticles.ts 81.28% <0.00%> (+1.06%) ⬆️
src/util/articleRenderers.ts 71.27% <0.00%> (+9.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pavel-karatsiuba pavel-karatsiuba marked this pull request as ready for review February 16, 2023 13:03
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42 kelson42 merged commit 71ab578 into main Feb 18, 2023
@kelson42 kelson42 deleted the vikidia-fixes branch February 18, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vikidia ZIM files are all ~2 years old
2 participants